Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why the graph is not modified on bulk delete? #125

Open
msk-apk opened this issue Aug 23, 2024 · 3 comments
Open

why the graph is not modified on bulk delete? #125

msk-apk opened this issue Aug 23, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@msk-apk
Copy link

msk-apk commented Aug 23, 2024

On seeing the code, bulk delete just deletes the data from node. Graph is not modified on bulk delete. Am i missing anything? Will there be any limitation as the neighbour id list is not modified? Do we need to implement the algorithm for delete as in fresh diskann?

@msk-apk msk-apk changed the title why the graph is not modified on delete? why the graph is not modified on bulk delete? Aug 23, 2024
@msk-apk
Copy link
Author

msk-apk commented Aug 30, 2024

any one knows the reason behind not implementing fresh diskann for delete?

@cevian
Copy link
Collaborator

cevian commented Sep 23, 2024

The queries remain correct because we ignore deleted nodes at query-time. But it is true we don't free disk space. Ideally such cleanup would be done in the VACUUM process but it hasn't yet been implemented

@cevian cevian added the enhancement New feature or request label Sep 23, 2024
@msk-apk
Copy link
Author

msk-apk commented Sep 25, 2024

ok that clears my question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants