Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

Use incoming context from query endpoints #1205

Closed
antekresic opened this issue Feb 28, 2022 · 1 comment · Fixed by #1610
Closed

Use incoming context from query endpoints #1205

antekresic opened this issue Feb 28, 2022 · 1 comment · Fixed by #1610
Assignees
@alejandrodnm
Labels
epic/improvements-q3-2022 good first issue Good for newcomers Performance Improvements that are specifically related to performance
Milestone
1.0

Comments

@antekresic
Copy link
Contributor

Running long-term queries unintentionally can create adverse effects to the system performance. We should be using the incoming request context in order to cancel any DB queries we are running.

We should also use some sort of context timeout in addition to this to limit each query duration.
@antekresic antekresic added the Performance Improvements that are specifically related to performance label Feb 28, 2022
@VineethReddy02 VineethReddy02 added this to the 1.0 milestone Mar 2, 2022
@VineethReddy02 VineethReddy02 added the good first issue Good for newcomers label Aug 17, 2022
@cevian
Copy link
Contributor

cevian commented Aug 17, 2022

Separated the db pools for read/write but context propagation should also be investigated

@alejandrodnm alejandrodnm self-assigned this Aug 31, 2022
@alejandrodnm alejandrodnm mentioned this issue Sep 2, 2022
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alejandrodnm alejandrodnm

Labels
epic/improvements-q3-2022 good first issue Good for newcomers Performance Improvements that are specifically related to performance
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Propagate context from query requests timescale/promscale
5 participants
@cevian @ssola @antekresic @alejandrodnm @VineethReddy02