Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please match Timescaldb's supported PostgreSQL versions #453

Closed
jaskij opened this issue Jun 23, 2022 · 5 comments
Closed

Please match Timescaldb's supported PostgreSQL versions #453

jaskij opened this issue Jun 23, 2022 · 5 comments
Labels
proposed-feature A proposed feature or function to ease a task

Comments

@jaskij
Copy link

jaskij commented Jun 23, 2022

What's the functionality you would like to add

For timescaledb-toolkit to support the same PostgreSQL versions as TimescaleDB

How would the function be used


Why should this feature be added?

Currently, there is a very long delay in the toolkit supporting PostgreSQL 14 - none of the released versions do, although Timescale itself has had that support since 2.5.0 in October last year.

What scale is this useful at?

Any installation wanting to upgrade to PostgreSQL 14

Drawbacks

It puts more stress on the maintainers to actually keep up to date.

Open Questions

Are any questions we'd need to address before releasing this feature?

Comments

After having written this issue, but before submitting, I have actually tried building and using 1.7.0 with PostgreSQL - to my surprise it actually works, at least as far as our project goes. But the README only lists versions the toolkit is tested against - and those only mention pg12 and pg13, so it makes it seem as if pg14 is not supported.

@jaskij jaskij added the proposed-feature A proposed feature or function to ease a task label Jun 23, 2022
@jerryxwu
Copy link
Contributor

@jaskij The Testing section of the README has PG12, PG13 and PG14 all listed. I'm think perhaps the use of PG13 in the Setup introductions made you think PG14 is not supported?

Thank you for you feedback. We will make PG14 support stand out more. As an example, we will update the README to use PG14 in the Setup instructions.

@jaskij
Copy link
Author

jaskij commented Jun 23, 2022

@jerryxwu two points here:

There should be a separate section for supported versions. Or are you implying the toolkit isn't release ready yet, hence only the Testing section?

The README at the tag does not list pg14 - that's what started this whole thing.

One more question from me then: does timescaledb-toolkit 1.7.0 support PostgreSQL 14 or not? You can't update the tag, but I can at least point the AUR maintainer to your answer so they can update their package.

@jerryxwu
Copy link
Contributor

@jaskij Great points. Really appreciate your feedback.

@jerryxwu
Copy link
Contributor

jerryxwu commented Jul 5, 2022

@jaskij Sorry just realized that I've missed your last question.

One more question from me then: does timescaledb-toolkit 1.7.0 support PostgreSQL 14 or not?

Yes, PG 14 is supported.

@rtwalker
Copy link
Contributor

closed by #463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposed-feature A proposed feature or function to ease a task
Projects
None yet
Development

No branches or pull requests

3 participants