Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: gMLP and GatedTabTransformer. #354

Closed
radi-cho opened this issue Jan 4, 2022 · 3 comments
Closed

Feature request: gMLP and GatedTabTransformer. #354

radi-cho opened this issue Jan 4, 2022 · 3 comments
Labels
enhancement New feature or request PR Pull request

Comments

@radi-cho
Copy link

radi-cho commented Jan 4, 2022

Hello and thank you for the maintenance of this helpful library.
I see that Multilayer Perceptron (Wang, 2016) and TabTransformer (Huang, 2020) are some of the implemented models. Recently we have been researching the impact of gating in ML architectures for tabular modeling and would request the addition of two new architectures.

If the maintainers of the project agree with this proposal I can directly open pull requests with implementations adapted for the format of the tsai library.

@radi-cho
Copy link
Author

@oguiza Should I open a PR?

@oguiza
Copy link
Contributor

oguiza commented Jan 11, 2022

Hi @radi-cho,
Sorry for my late response.
Thanks for volunteering to add those 2 models. It'd be great to have a 2 PRs adding them to tsai.
Please, bear in mind the CONTRIBUTING.md guideline to create the PR to ensure they pass the CI tests.
It's also important to ensure the arguments of the models are aligned to the other models (you can use TabTransformer as a template). This is required so models can then be easily replaced in the learner.
Please, let me know if you find any issues or need any help during the process.

@radi-cho
Copy link
Author

Opened #362

@oguiza oguiza added the enhancement New feature or request label Jan 18, 2022
@oguiza oguiza added the PR Pull request label Feb 25, 2022
@radi-cho radi-cho closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR Pull request
Projects
None yet
Development

No branches or pull requests

2 participants