Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using version handler for new Base functions #55

Closed
aminya opened this issue Dec 29, 2019 · 2 comments · Fixed by #71
Closed

using version handler for new Base functions #55

aminya opened this issue Dec 29, 2019 · 2 comments · Fixed by #71

Comments

@aminya
Copy link
Contributor

aminya commented Dec 29, 2019

For Julia 1, Base.BroadCast.restart_copyto_nonleaf! is not defined which results in error:
https://travis-ci.com/aminya/Atom.jl/jobs/270937636#L418

https://github.com/aminya/Atom.jl/blob/dfbc1119d38fa9974957b81e11e75cb3436f9e49/deps/SnoopCompile/precompile/precompile_Atom.jl#L165

Parcel doesn't seem to filter this out for old Julia

@timholy
Copy link
Owner

timholy commented Dec 31, 2019

Parcel only tries to eval the statement on whatever version of Julia is doing the snooping; it doesn't check whether the statement can be evaled on any other version of Julia. If we could launch several Julia versions and pass messages between them, we could fix this. Just trying to build the package with a given precompile file is a pretty blunt tool because it's awkward at that point to figure out which line(s) are causing the problem.

@aminya
Copy link
Contributor Author

aminya commented Jan 27, 2020

If we add a new blacklist entry for the user to enter the version_blacklist and even os_blacklist, we can add a if else or a try catch for those sentences in precompile signatures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants