Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Be able to configure shared directory name #44

Open
adamj88 opened this issue Nov 25, 2016 · 3 comments
Open

[FR] Be able to configure shared directory name #44

adamj88 opened this issue Nov 25, 2016 · 3 comments

Comments

@adamj88
Copy link

adamj88 commented Nov 25, 2016

The shared/ directory name is hard coded here: https://github.com/timkelty/shipit-shared/blob/master/lib/init.js#L21

Would it be possible to be able to set this in the configuration, falling back to shared/ to prevent any BC break?

@timkelty
Copy link
Owner

This already should be configurable...
Try settings shipit.config.shared.basePath - it defaults to path.join(shipit.config.deployTo, 'shared'), but can be set manually.

@timkelty
Copy link
Owner

Unless you specifically just wanted to change the directory name and not the whole path...

@adamj88
Copy link
Author

adamj88 commented Dec 2, 2016

Thats correct, my suggestion is to be able to configure the directory name independently.

So shipit.config.deployTo as the path, and a separate configuration for the 'shared' string, shipit.config.dirName possibly?

I've got a similar issue open on shipit-deploy: shipitjs/shipit-deploy#128 - the net result should be that you're able to configure all directory names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants