Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultLanguage sets pre tag but not code tag #60

Closed
ddoan opened this issue Jun 24, 2023 · 3 comments · Fixed by #61
Closed

defaultLanguage sets pre tag but not code tag #60

ddoan opened this issue Jun 24, 2023 · 3 comments · Fixed by #61

Comments

@ddoan
Copy link

ddoan commented Jun 24, 2023

Hi Tim, I think there's a small issue with the new option. It doesn't quite produce the same result as specifying a language.

Screenshot 2023-06-24 at 9 11 09 AM
@timlrx
Copy link
Owner

timlrx commented Jun 25, 2023

The difference is that language-js is not added as a class in the default code blocks? Ok, will fix it to be the same. I have tested that the syntax highlighting is the same but let me know if you see any differences.

@timlrx timlrx mentioned this issue Jun 25, 2023
Merged
@timlrx
Copy link
Owner

timlrx commented Jun 25, 2023

Should be fixed in the newly released 1.6.1

@ddoan
Copy link
Author

ddoan commented Jun 25, 2023

Confirmed on my end. Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix - add class info for default language timlrx/rehype-prism-plus
2 participants
@ddoan @timlrx