Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kbar Conflicting peer dependency #1041

Open
henryaltman opened this issue Oct 19, 2024 · 1 comment
Open

kbar Conflicting peer dependency #1041

henryaltman opened this issue Oct 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@henryaltman
Copy link

henryaltman commented Oct 19, 2024

Describe the bug
kar depends react-virtual,but react-virtual has been deprecated, and change new project name @tanstack/react-virtual

react-virtual v2 only support fine with React 17, Conflicting React 18. ref See issues #2307

npm install any new dep will show below:

npm warn ERESOLVE overriding peer dependency
npm warn While resolving: react-virtual@2.10.4
npm warn Found: react@18.3.1
npm warn node_modules/react
npm warn   peerOptional react@">= 16.8.0 < 19.0.0" from @docsearch/react@3.6.1
npm warn   node_modules/@docsearch/react
npm warn     @docsearch/react@"^3.5.0" from pliny@0.2.1
npm warn     node_modules/pliny
npm warn   20 more (@giscus/react, @headlessui/react, @mdx-js/react, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer react@"^16.6.3 || ^17.0.0" from react-virtual@2.10.4
npm warn node_modules/kbar/node_modules/react-virtual
npm warn   react-virtual@"^2.8.2" from kbar@0.1.0-beta.45
npm warn   node_modules/kbar
npm warn
npm warn Conflicting peer dependency: react@17.0.2
npm warn node_modules/react
npm warn   peer react@"^16.6.3 || ^17.0.0" from react-virtual@2.10.4
npm warn   node_modules/kbar/node_modules/react-virtual
npm warn     react-virtual@"^2.8.2" from kbar@0.1.0-beta.45
npm warn     node_modules/kbar

can upgrade and solve this problem? thanks

@henryaltman henryaltman added the bug Something isn't working label Oct 19, 2024
@timlrx
Copy link
Owner

timlrx commented Oct 25, 2024

Related to timc1/kbar#330, would be best to be fixed on kbar side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants