Add persistent toasts

[hudochenkov]

Sometimes we need to show toast until it's dismissed by user or programmatically. E. g. connection lost and notification is shown until it's back online. Or some long or slow process happens.

It is not always possible to use toast.promise for that. Currently I use very long duration to simulate persistent toast.

Is it possible to add persistent toast, which doesn't have any timers inside them? Then it would possible to do:

const id = toast('No connection.', { persistent: true });

toast('Connected.', { id, persistent: false })

[timolins]

Would { duration: Infinity } do the trick for you? Should work well, without adding more options to the API.

[hudochenkov]

Just tried. Toast won't even show. I tried both my custom toast and default one.

[timolins]

You are right. That's weird. I'll look into this.

Edit: This is why: denysdovhan/wtfjs#61 (comment)

Will try to find a different solution, as this seems like a valid use case.

[timolins]

Does toast("Endless", { duration: -1 }) make sense to you? Was the easiest fix I can think of, not sure if it's the best API though.

[ghost]

@timolins I think it would be better to just do if (!isFinite(duration)) { don't set timeout } and keep using the { duration: Infinity } API.

[timolins]

Thanks for the feedback! I agree with you, using Infinity seems like the more intuitive API. Will update and merge the PR :)