-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lag between tap and the tab changing #47
Comments
Hrmmm, strange. Please try using react-navigation's own TabBar Implementation and check if the delay is still there or gone. I currently can't find a reason why the BottomNavigation would cause a delay.
|
I'm also facing the same problem. Tab change is not that smooth.. |
I need more informations on this. /cc @buckydroid @Flavien Mostly I need to know if the delay is gone when you switch to react-navigations TabBar. Cause there is a similar issue in react-navigation: react-navigation/react-navigation#2631 |
Related: I have also noticed that if you click a bunch of tabs fast (easiest to reproduce with two thumbs on a real device), tab switch keeps repeating forever, and device becomes non-responsive. |
@wildseansy I don't think the behaviour you described is related to this particular issue. It seems like it's an issue in react-navigation, but there's neither a response in their issue nor a response here. |
The same seem to happen even without react-navigation integration. |
I tested the BottomNavigation without the react-navigation integration, using this Snack: https://snack.expo.io/SJU96kK0Z I can't see a delay, at least on my device. The screen updates immediately. |
i'm also see some lag on iphone 6. I disable PressRipple Animation and RippleBackground Animation and now all good. |
I once again tested this and can't see any delay. (Tested it with and without react-navigation, on two android phones, Android emulator and iOS simulator. I used the code from the examples.) My assumption is that such delays are caused by the performance of the app, not the BottomNavigation itself. If you do a lot of stuff in your Screens, maybe together with redux, you could have many unnecessary re-renders. After digging around a bit and reading the same issues in react-navigation's Issues, I stumbled across react-navigation/react-navigation#608 (comment) and react-navigation/react-navigation#608 (comment). The advices in those comments are really good to improve the performance of your app, even if you aren't using react-navigation. If you notice a delay with a very simple App, please comment below with more details (OS, Device, Software-Version, RN-Version, Code, etc). |
I'm using react-native-material-bottom-navigation with react-navigation and Redux.
When tapping a tab, there is a half a second delay between tapping and the navigation actually happening. I can see the ripple effect on the tab is also delayed.
Any idea why it's doing that?
The text was updated successfully, but these errors were encountered: