feat: remove useWSL option
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecrs
force-pushed
the
felipecrs/deprecate-wsl
branch
from
a94cbfa
to
2873803
Compare
felipecrs
force-pushed
the
felipecrs/deprecate-wsl
branch
4 times, most recently
from
b862e06
to
48b1df7
Compare
felipecrs
force-pushed
the
felipecrs/deprecate-wsl
branch
from
48b1df7
to
c25a29e
Compare
timonwong
pushed a commit
that referenced
this pull request
Feb 4, 2021
## [0.13.0](v0.12.3...v0.13.0) (2021-02-04) ### Features * remove `useWSL` option ([#121](#121)) ([9967218](9967218))
|
🎉 This PR is included in version 0.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thank you, good job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option only seems to cause misleading when using the extension on Windows. Now that the extension is shipped with the
shellcheckbinaries bundled, it will work on Windows for the majority of the users, thus no need for proxying its use through WSL.This option and its approach are now totally removed from the documentation to prevent users from mistakenly believe that they need to use it in Windows.
To simplify:
If you really know how it works and wants to keep using it in a similar way, you can do something like:
Using the extension on Windows and loading the shellcheck binary from WSL
To make this work, you also need to use a shim. Here is an example of a
shellcheck.cmd:Closes #117, closes #9 and closes #87.