Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: conditionally run tests based on what changed #675

Open
timotheecour opened this issue Mar 28, 2021 · 0 comments
Open

CI: conditionally run tests based on what changed #675

timotheecour opened this issue Mar 28, 2021 · 0 comments

Comments

@timotheecour
Copy link
Owner

timotheecour commented Mar 28, 2021

proposal

  • add logic to detect whether we should run a test or not depending on PR content: if we can prove that a PR won't affect a test, skip it
  • but still run all tests on a commit (as opposed to pull_request), as a safety net in case the above logic is wrong
  • also provide a [ci force] flag to avoid skipping tests in a PR
  • the logic should be reusable and written in nim so that all CI pipelines can reuse it

benefits

links

past efforts related to this: note that a suitable approach should use nim code instead of bash scripts

[WIP] fix #6999 (allow [nimDocOnly] in commit msg); fix #13477 (flaky nodejs install); log PR url (+other info) in runCI logs by timotheecour · Pull Request #13556 · nim-lang/Nim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant