Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double spacing while displaying the source code in the generated web pages? #39

Open
dragondive opened this issue Mar 29, 2023 · 0 comments · May be fixed by #42
Open

Double spacing while displaying the source code in the generated web pages? #39

dragondive opened this issue Mar 29, 2023 · 0 comments · May be fixed by #42

Comments

@dragondive
Copy link

Hello @timothycrosley,

First of all, thank you very much for your other project portray. I must express my appreciation especially for how easy it is to use. I have never experienced such great UX in any of the other tools I have used (and not just in the area of python document generation).

Now, coming to the current question. I noticed that the View Source there uses double spacing in the source code.

I figured out by reading the source that it comes from the \n in the following line of this (pdocs) project (and similar lines in a couple of places elsewhere in the file). I verified this by forking and testing locally.

${"\n ".join(func.source)}

Is the double spacing done to make the source code "easy on the eyes" in the web browser?
Would it be okay to provide an option to disable the double spacing?


Note: I only want to understand the reason why it was done in this way, and I'm not "complaining" about it. 😄 I intend to introduce portray to my colleagues and friends. I want to be prepared with an answer to a question I can already anticipate. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant