Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofxVideoRecorder seems to fail when the path to app (and ffmpeg) has spaces in it #68

Open
ofZach opened this issue May 7, 2021 · 2 comments

Comments

@ofZach
Copy link

ofZach commented May 7, 2021

I noticed a couple of issues -- it's all a little hazy but some notes if helpful

a) open(...) used to get the file handle for the pipes, seems unhappy when the path has spaces
b) the commands for ffmpeg seem unhappy when there is spaces in the path to ffmpeg

about (a) I am not 100% certain but I think it's an issue.
the solution for me for (a) was to use a relative path without spaces -- since I'm doing something kind of funky and having ffmpeg inside the app bundle and for (b) the solution was to modify how the command is put together and wrap the path to ffmpeg in some quotes.

I'll investigate this some more before a PR but in case it's helpful, just writing some notes here.

@ofZach
Copy link
Author

ofZach commented May 7, 2021

(ps: what a great add-on. ridiculously helpful...)

@timscaffidi
Copy link
Owner

Hi Zach!

Thanks for the bug report. There have been issues in the past with spaces in filenames, and ffmpeg seems to be extra finicky in that regard. I'll take a look soon, and happy to accept a PR if you're able to pin it down in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants