[pr discuss] Add {{git_creation_date_localized}}

[PegasisForever]

Hi!

I added the ability for this plugin to add creation dates to pages. (Because I need it for my personal blog) (repo)

Since CONTRIBUTING.md wrote "...That means not extending the functionality of this plugin", I'm wondering whether my pr of adding this functionality will be accepted?

If it won't, I won't bother writing tests for it :)

[timvink]

Hi @PegasisForever !

Thanks for this :) I had a look at the changes you made link and looks nice!

I'm open to adding a git_creation_date_localized. It's relatively cheap, because it just means a bit more parsing of the git log output we already have. Some thoughts:

• I wonder what the performance overhead is of getting the full logs instead of just the top one for large projects (see here). Probably better to only get the full logs when you need it (so when enable_creation_date is True), otherwise keep n=1.
• mkdocs-material offers native support for git-revision-date-localized including all required translations (see f.e. here or here). We'll have to align with the author, update the source_date partial and language templates. Would you be willing to pick that up also?

We can align on implementation specifics if you open a PR. I have been planning to create a documentation website for this plugin, I will pick that up so we can document this feature there.

[PegasisForever]

Performance:

I found out git log has an reverse option so we can just get the first log in the reverse order.

Theme integration:

Yes, I'll deal with that.

I'll open a pr later today (or tomorrow).