-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.1 creates git log warnings that fail mkdocs strict mode #89
Comments
Thanks for reporting, will look into it in 1-2 weeks or so (currently on holiday) |
Thanks. I am now thinking this might be unrelated and just a coincidence. I'll verify and close once I confirm. |
Did you verify yet? You mentioned "build failures" but you are showing a warning (it shouldn't break the build). |
@timvink - Sorry, I wasn't able to track down the root cause yet, but I'm pretty sure it's not related to the `v1.0.1 change. I'll close this and re-open if needed.
This fails a build only used with the mkdocs |
@andrewthauer @timvink Why is this ticket closed as the current bug prevents people from using strict mode in their pipelines, something that is known to be a good practice. |
@ssbarnea I wasn't able to confirm the issue was related to this plugin. Can you reproduce and confirm it is? |
Yes. I disabled the plugin for now. |
It could also be an issue with how |
I did not use mkdocs for very long time, so I cannot say if they changed something recently. Still, I almost always tried to run tools with strict mode (like sphinx), so I would not miss problems. Still, gue to the nature of this plugin, if you add How this can be sorted? I am not sure. Maybe there is an info/notice level that does not become an error when you run in strict? For the moment I disabled the plugin because it did not add essential functionality for me. For me it was more important to be able to have a default strict mode. |
FYI, this issue will be picked up in #108 |
Fixed, new plugins:
- git-revision-date-localized:
strict: false |
After upgrading to
v1.0.1
we started seeing build failures with the following:Is it possible #88 is causing these issues? It's a bit odd since we do fetch the entire history, but the warning says it's falling back to the build date for some reason. In any case, since it's a warning, if you are using
mkdocs build --strict
it will fail.The text was updated successfully, but these errors were encountered: