Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character encoding errors in created PR message #1510

Open
1 task done
mikeKuester opened this issue Dec 10, 2024 · 3 comments
Open
1 task done

Character encoding errors in created PR message #1510

mikeKuester opened this issue Dec 10, 2024 · 3 comments

Comments

@mikeKuester
Copy link

Describe the bug
The created PR message contains invalid characters in the name of the author of a fix.

image

It should look like this (created PR message from dependabot-script):

image

Categorization

Repository

To Reproduce
Steps to reproduce the behavior:
You need a package with fixes from a user who has non ASCII chars in his user name like https://github.com/icsharpcode/SharpZipLib

Expected behavior
The chars should be valid.

Logs and screenshots
Screenshots see above.

Extension (please complete the following information):

  • Host: Azure DevOps
  • Version 2.39.1099

Server (please complete the following information):

  • Region East US 2
  • Version ?

Additional context
Add any other context about the problem here.

@rhyskoedijk
Copy link
Contributor

rhyskoedijk commented Dec 11, 2024

@mikeKuester thanks for the report.
This might be a limitation of dependabot-cli, which outputs text using utf-8 encoding. I will investigate to see if there is anything that can be done in the scope of this project to fix the issue.

@mburumaxwell
Copy link
Contributor

@mikeKuester is this still happening?

@rhyskoedijk Could this be because dependabot-core forces the encoding to UTF-8, trims to 4000 characters then forces it back?

@mikeKuester
Copy link
Author

@mburumaxwell yes, is still happening with version 2.42.1174

Fixes:
� specialized tar extract traversal by nils m��s��n
� [#635] bzip2 use explicit feature defs for vectorized memory move by Jackson Wood
� [#645] tar create translated files in temp by nils m��s��n

And it's not only the name, the first character (green curve) is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants