-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OnActionClickListener is not safe #33
Comments
This problem occurs everywhere: when you click on View, when navigating through Fragments and Activitys and other actions in the UI. As for the commit 6f54f36, I checked it in work, everything is fine. Thanks! |
You are right and that was what led to the development of this library in the first place. In the early days, as I recalled, Material Design stated that user input should never be blocked even if something is in progress, which is just impossible sometimes. As we cannot predict what user will be doing over the few seconds of the process in background, the simplest method is just to block the whole screen and show a progress bar to notify user that something is happening. Anyway, thanks for the confirmation. Releasing as v6.4.2. If you can offer better, faster way to add the overlayLayout, feel free to submit a pull request. Currently, when |
Click on the ActionButton will execute the onActionClick() method and automatically close the SnackProgressBar, however, there is an opportunity (accidentally or intentionally) to click on it several times before the SnackProgressBar closes. The onActionClick() will execute twice, leading to unpredictable results.
Please lock the ActionButton after the first click.
The text was updated successfully, but these errors were encountered: