Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy/docker-compose.yml should be usable w/o setup.sh #367

Closed
mmlb opened this issue Nov 16, 2020 · 1 comment · Fixed by #537
Closed

deploy/docker-compose.yml should be usable w/o setup.sh #367

mmlb opened this issue Nov 16, 2020 · 1 comment · Fixed by #537
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@mmlb
Copy link
Contributor

mmlb commented Nov 16, 2020

I like testing things on my laptop using docker-compose.yml. It's not easy to do so at the moment. I need to setup some env vars and generate certificates which is all orchestrated via setup.sh. I do not want to run setup.sh on my laptop as that tries to mess with certs and who know what else globally (I didn't check).

Expected Behaviour

cd deploy; docker-compose up --build -d should get me a pretty good dev/test env.

Current Behaviour

Lots of env vars missing, the docker-compose.yml isn't even valid and tink-server fails to start because tls certs are not generated.

Possible Solution

Put more defaults into docker-compose.

Run the tls container from docker-compose too. If the tls certs happen to be generated already (either from setup.sh or from previous run) it would do nothing.

@mmlb
Copy link
Contributor Author

mmlb commented Jan 21, 2021

Related to #418

@tstromberg tstromberg added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 27, 2021
@jacobweinstock jacobweinstock mentioned this issue Sep 3, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants