Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Go Report Card compatibility #512

Closed
3 tasks
nicklasfrahm opened this issue Jun 29, 2021 · 1 comment · Fixed by #538
Closed
3 tasks

Improve Go Report Card compatibility #512

nicklasfrahm opened this issue Jun 29, 2021 · 1 comment · Fixed by #538
Assignees
@tstromberg
Labels
area/ci-cd-release good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
0.7.0

Comments

@nicklasfrahm
Copy link

Currently, the CI setup of this repository does not catch all the issues and warnings that Go Report Card catches. To solve this, we should make the CI tests more strict to:

  • consider cyclomatic complexity warnings as errors
  • consider linter warnings as errors
  • add Go Report card label to README.md
@jacobweinstock jacobweinstock added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 29, 2021
@tstromberg
Copy link
Contributor

I think this sounds like a great idea. Is anyone up to implement it?

@tstromberg tstromberg self-assigned this Aug 27, 2021
@tstromberg tstromberg added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 27, 2021
@tstromberg tstromberg mentioned this issue Sep 3, 2021
Merged
@displague displague added this to the 0.7.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstromberg tstromberg

Labels
area/ci-cd-release good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Introduce more stringent golangci-lint checks & address issues raised tstromberg/tink
5 participants
@tstromberg @displague @jacobweinstock @nicklasfrahm @gauravgahlot