Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tink-worker has a default uptime of 1h #591

Closed
mmlb opened this issue Feb 11, 2022 · 2 comments
Closed

Tink-worker has a default uptime of 1h #591

mmlb opened this issue Feb 11, 2022 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mmlb
Copy link
Contributor

mmlb commented Feb 11, 2022

By default tink-worker must run all its workflows and actions within 1 hour of its startup. This is because we have a default 1h timeout parameter that gets used as a timeout for a root context.Context which ends up being passed down to worker.ProcessWorkflowActions that then gets used for everywhere.

Expected Behaviour

tink-worker is able to stay up and running effectively forever.

Current Behaviour

This effectively caps tink-worker's uptime to 1h.

Possible Solution

Pass down the timeout to tink-worker's main event loop so it can use it to create a new timeout when needed, likely when a new workflow is being processed (as I suspect was the original intent, iirc).

Steps to Reproduce (for bugs)

See slack thread: https://cloud-native.slack.com/archives/C01SRB41GMT/p1644596207711939

  1. Start tink-worker
  2. Wait until the timeout period has elapsed (default 1h, could be less if shortened in step 1)
  3. Create a workflow targeting this tink-worker
  4. docker pulls will fail

Context

tink-worker is unable to process a workflow to completion

@mmlb mmlb added the kind/bug Categorizes issue or PR as related to a bug. label Feb 11, 2022
@mmlb
Copy link
Contributor Author

mmlb commented Feb 11, 2022

Reported by @swills

@mmlb
Copy link
Contributor Author

mmlb commented Apr 18, 2022

Should no longer be the case after #605

@mmlb mmlb closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant