You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we have this condition on loading object saved under different library version:
ifcurrent_etna_version[0] !=saved_etna_version[0] orcurrent_etna_version[:2] <saved_etna_version[:2]:
current_etna_version_str=".".join([str(x) forxincurrent_etna_version])
saved_etna_version_str=".".join([str(x) forxinsaved_etna_version])
warnings.warn(
f"The object was saved under etna version {saved_etna_version_str} "f"but running version is {current_etna_version_str}, this can cause problems with compatibility!"
)
We should simplify this condition and give a warning if version is different: current_etna_version != saved_etna_version, because we don't have forward or backward compatibility for saving.
🚀 Feature Request
Currently we have this condition on loading object saved under different library version:
We should simplify this condition and give a warning if version is different:
current_etna_version != saved_etna_version
, because we don't have forward or backward compatibility for saving.Proposal
Change the condition in
etna.core.mixins.SaveMixin._validate_metadata
Test cases
Fix tests:
tests.test_core.test_mixins.test_save_mixin_load_warning
(1, 5, 0), (1, 3, 0)
(1, 5, 0), (1, 5, 1)
(1, 5, 1), (1, 5, 0)
tests.test_pipeline.test_save_mixin_load_warning
tests.test_ensembles.test_save_mixin_load_warning
tests.test_models.test_save_mixin_load_warning
Additional context
No response
The text was updated successfully, but these errors were encountered: