Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Time bug with zero padding #42

Merged
merged 5 commits into from
Dec 20, 2022
Merged

fix(kit): Time bug with zero padding #42

merged 5 commits into from
Dec 20, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

https://github.com/Tinkoff/maskito/blob/fec6517212031c2edd893b6773fc06091fb56cad/projects/demo-integrations/cypress/tests/kit/time/time-mode.cy.ts#L77-L78

Does this PR introduce a breaking change?

  • Yes
  • No

@nsbarsukov nsbarsukov self-assigned this Dec 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2022

Visit the preview URL for this PR (updated for commit 08eb97b):

https://maskito--pr42-zero-padding-fix-oqtw699h.web.app

(expires Wed, 21 Dec 2022 13:05:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 61e4dea776cbea516b68c67840913d2edd88bb90

@nsbarsukov nsbarsukov changed the title [WIP] fix(kit): Time bug with zero padding fix(kit): Time bug with zero padding Dec 20, 2022
@nsbarsukov nsbarsukov marked this pull request as ready for review December 20, 2022 13:10
@nsbarsukov nsbarsukov merged commit 5ccc127 into main Dec 20, 2022
@nsbarsukov nsbarsukov deleted the zero-padding-fix branch December 20, 2022 14:11
This was referenced Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants