feat(angular): improve DI-approach #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 3081eb6): https://maskito--pr72-improve-angular-di-a-3eudwxst.web.app (expires Tue, 24 Jan 2023 13:02:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 61e4dea776cbea516b68c67840913d2edd88bb90 |
splincode
approved these changes
Jan 23, 2023
waterplea
approved these changes
Jan 24, 2023
| this.maskedElement?.destroy(); | ||
| this.maskedElement = new Maskito(this.elementRef.nativeElement, options); |
There was a problem hiding this comment.
Just a point to keep an eye on, we cannot be sure we have access to native element so in future we would also need some way to get native input without putting explicit maskito directive on it, and also make sure we can handle native input dynamic appearance and removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #36
Does this PR introduce a breaking change?