Merge pull request #302 from tinybirdco/iterate_api_endpoint_101

alrocar · web-flow · commit 0cd4aadc512c · 2024-05-27T22:17:51.000+02:00
Iterate api endpoint 101
diff --git a/iterating_api_endpoint/pipes/top_browsers.pipe b/iterating_api_endpoint/pipes/top_browsers.pipe
@@ -30,6 +30,9 @@ SQL >
               {% else %}
                 and date <= today()
               {% end %}
+              {% if defined(browser) %}
+                and browser = {{String(browser)}}
+              {% end %}
             group by
               browser
             order by
diff --git a/iterating_api_endpoint/tests/top_browser_default.test b/iterating_api_endpoint/tests/top_browser_default.test
@@ -1 +1 @@
-tb pipe data top_browsers --date_from 2024-01-11 --date_to 2024-01-12 --format CSV
+tb pipe data top_browsers --date_from 2024-01-11 --date_to 2024-01-12 --browser chrome --format CSV
diff --git a/iterating_api_endpoint/tests/top_browser_default.test.result b/iterating_api_endpoint/tests/top_browser_default.test.result
@@ -1,5 +1,3 @@
-"browser","device","visits","hits"
-"chrome","desktop",1,2
-"firefox","desktop",1,1
-"chrome","mobile-android",1,1
+"browser","visits","hits"
+"chrome",2,3
 

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-tb pipe data top_browsers --date_from 2024-01-11 --date_to 2024-01-12 --format CSV`
	`1`	`+tb pipe data top_browsers --date_from 2024-01-11 --date_to 2024-01-12 --browser chrome --format CSV`