Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUB75] ABC/ABCDE panels support #630

Open
funkycode opened this issue Dec 20, 2023 · 2 comments
Open

[HUB75] ABC/ABCDE panels support #630

funkycode opened this issue Dec 20, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@funkycode
Copy link

dPin.Configure(machine.PinConfig{Mode: machine.PinOutput})

The implementation supports only ABCD panels, while there are some panels that have only ABC and moreover from my understanding there are also panels with ABCDE pins.

I have ABC only panel on it's way from AliExpress that I want to test, if needed to adjust this implementation and make a PR once it is working.

Should we have multiple implementations or should we add something like ENUM to define which type it is?

Here is thread for reference on differences and implementation o other project that I am going to use as help to adjust tinygo implementation for ABC only support (can't make ABCDE one as I lack the led matrix of that type)

@conejoninja
Copy link
Member

Depending on how much difference there are between versions.

Personally, I would add a new constructor... like func NewABC(b drivers.SPI, latPin, oePin, aPin, bPin, cPin machine.Pin) Device {

and use some sort of variable to keep track which panel type is and how to handle the pins. That's assuming there is not much difference and we could use the hub75 package for both. If there's a major difference on how to handle the code, then I'll vote for hub75 (as is) and a new hub75abc driver

@funkycode
Copy link
Author

Well, at the end one I got utilizes all 4 channels. I have another matrix that is on the way, in case it will use only ABC I will try to implement it, in case not - unfortunately i would not be able to do so as I would need HW to test implementation :(

@deadprogram deadprogram added the enhancement New feature or request label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants