interp: improve unknown opcode handling

kenbell · aykevl · commit adadbadec30b · 2023-09-21T01:18:05.000+02:00
diff --git a/interp/compiler.go b/interp/compiler.go
@@ -49,7 +49,10 @@ func (inst *instruction) String() string {
 		operands[i] = op.String()
 	}
 
-	name := instructionNameMap[inst.opcode]
+	name := ""
+	if int(inst.opcode) < len(instructionNameMap) {
+		name = instructionNameMap[inst.opcode]
+	}
 	if name == "" {
 		name = "<unknown op>"
 	}

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,10 @@ func (inst *instruction) String() string {`
`49`	`49`	`operands[i] = op.String()`
`50`	`50`	`}`
`51`	`51`
`52`		`- name := instructionNameMap[inst.opcode]`
	`52`	`+ name := ""`
	`53`	`+ if int(inst.opcode) < len(instructionNameMap) {`
	`54`	`+ name = instructionNameMap[inst.opcode]`
	`55`	`+ }`
`53`	`56`	`if name == "" {`
`54`	`57`	`name = "<unknown op>"`
`55`	`58`	`}`