Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go1.20: add StringData, String, SliceData #3407

Closed
QuLogic opened this issue Jan 23, 2023 · 1 comment
Closed

go1.20: add StringData, String, SliceData #3407

QuLogic opened this issue Jan 23, 2023 · 1 comment

Comments

@QuLogic
Copy link
Contributor

QuLogic commented Jan 23, 2023

As a followup to #3391, most of go test passes, except for:

        --- FAIL: TestBuild/Host/rand.go (3.14s)
        --- FAIL: TestBuild/Host/filesystem.go (1.90s)
        --- FAIL: TestBuild/Host/env.go (1.91s)
        --- FAIL: TestBuild/Host/testing.go (8.07s)
        --- FAIL: TestBuild/Host/stdlib.go (3.89s)
        --- FAIL: TestBuild/Host/json.go (5.78s)
        --- FAIL: TestBuild/Host/embed/ (2.08s)

This is due to the following:

    main.go:1174: /usr/lib/golang/src/strings/builder.go:48:39: todo: builtin: SliceData
    main.go:1174: /usr/lib/golang/src/strings/builder.go:48:22: todo: builtin: String
    main.go:1174: /usr/lib/golang/src/strings/clone.go:27:22: todo: builtin: String

Upstream's proposal for this is here: golang/go#53003

According to the release notes, this is a followup to Go 1.17's Slice, so there might be some inspiration from 255f356.

@QuLogic
Copy link
Contributor Author

QuLogic commented Jan 23, 2023

Sorry, I forgot to check dev! I see this is implemented already.

@QuLogic QuLogic closed this as completed Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant