Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve windows support #12

Closed
43081j opened this issue Jun 17, 2024 · 0 comments · Fixed by #13
Closed

improve windows support #12

43081j opened this issue Jun 17, 2024 · 0 comments · Fixed by #13

Comments

@43081j
Copy link
Member

43081j commented Jun 17, 2024

This will currently work on windows but in an inconsistent manner.

For example:

x('eslint', ['--help']); // works on linux, fails on windows

x('eslint.cmd', ['--help']); // works on windows, fails on linux

The only solution to this seems to be to use a shell on windows, either by using shell: true or by calling cmd.exe with the target command as an argument.

If we do that, we may need to escape some things (e.g. the command name if it has spaces in).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant