-
Notifications
You must be signed in to change notification settings - Fork 525
Google Play Update #785
Comments
We are also facing the same issue in google play console while uploading app to play store. |
It seems Tipsi will not update the stripe module, as there is an official library from Stripe Itself. I'm using stripe for Google pay and Apple Pay only. Even though I haven't used the Card payment, It is mandatory to update to 16.9.0/16.10.0 in order to prevent rejection. One Good Way: Open Android Studio -> Go to Build.gradle of tipsi-stripe -> Update Stripe SDK to 16.9.0 (it will show you the tooltip dialog box to update to 16.9.0, as you hover over implementation Click Sync now (in the header part of build.gradle) Go to tipsi-stripe -> java ->com.gettipsi.stripe The following Files will get affected after the update:
Open the respected files and change the old imports to new imports. You can fix most of the errors by hover over the error and do recommended fix. Replace old code with below: Converters.java
Open GoogleApiPayFlowImpl.java
StripeModule.java
Use the Above code (It is working fine with no build error) if you use Wallets Alone. I have removed some codes related to card payments after the updates because of confusion. If you have time and know java, you can update the error codes manually. Thank you. |
hey @ImPDP , if you send this as a PR I will merge it and release :D |
If you have a solution that includes card payments, I would greatly appreciate it, my Java sucks. @ImPDP |
Sure @cybergrind. But I can't right now. I'll do that in a day or two. @designerofthing, I did not remove all of the card payments code. As I'm using only GPay, I didn't care about some error thrown in the card token related to bank account methods/functions. I'll check again and try not to remove the codes if I'm making the PR. Still, it will be good, If @cybergrind or anyone, test it before merging. |
@cybergrind So when we expecting an update in this library to fix this issue?? |
I've submitted the PR above with the changes suggested above by @ImPDP and a couple of other to get it to build for me. This works for my fairly narrow use cases which only involves calls to |
i will test |
my build fails:
See http://g.co/androidstudio/manifest-merger for more information about the manifest merger. Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. FAILURE: Build failed with an exception.
BUILD FAILED in 16s |
Same here for android build |
Element uses-library#org.apache.http.legacy at AndroidManifest.xml:30:7-85 duplicated with element declared at AndroidManifest.xml:20:7-85 See http://g.co/androidstudio/manifest-merger for more information about the manifest merger.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. FAILURE: Build failed with an exception.
|
make sure the Google Play services are with version 17 or above. |
Using version 17.0.0 |
To get it to work for me I had to bump my apps build:gradle dependency to 3.5.4 in
|
@wijskinner updating classpath("com.android.tools.build:gradle:3.5.2") to classpath("com.android.tools.build:gradle:3.5.4") worked for me |
This seemed to be ok for the methods I listed above, however I have just tested this with an auth requiring stripe test card
So I would say some more work needed. Will take a look if I have time tomorrow. |
Also thanks to @cybergrind for moving so quickly. But could we make this a beta at best. With a nice warning about probably breaking everything if possible. |
@wijskinner :D it is released as a beta, so users must explicitly install it |
Phew. 😄 |
OK - super easy fix for that 3ds dialog issue. Just needed to add a:
In |
Fix is there ☝️ for anyone who needs it. I'm having to use a fork anyway as we can't move our app to target iOS11 so I'm branching off tipsi-stripe 8.0.2 with the above fixes added. In any normal scenario we would have moved our app to the official stripe-react-native, but we're actually in the process of moving away from stripe so having to use a sticky plaster to keep google happy just for the next month or so. |
Hi all, will this fix be released in a version > 9.1.0 soon. I can't see a beta release at the moment and I'm also stuck with the error:
I can go through and make the suggested changes but if a new version is being imminently released, I'll hold off. |
ok, now we have beta 9.1.1 @DanGDroid @saadnaveed94 your turn |
Hi all, Need help After updating to the latest version I'm getting this error on running Archive
Tried excluding arm64 |
recent beta version has change in Java code only. ios directory is untouched. try 9.1.0. if you face same error, raise new issue. |
Can someone help on this please @wijskinner @ImPDP @saadnaveed94 @cybergrind |
I haven't tried that method @hbole. Or any method that isn't the ones I listed above I'm afraid. That error seems to be implying you are mixing test/live stripe. How did you generate the token - are you sure it was with your live key? Will have a quick look in the stripe-android code now for anything obvious. |
@wijskinner I was using this beta version of |
The error suggests you are reusing an idempotency_key in your params (that has been used previously) with different other params. See this answer on stack overflow: https://stackoverflow.com/a/51281228/5222819 . Are you trying to redo a previously failed transaction - not sure this would work if the first was made on an earlier SDK? I don't see anything in the code to indicate this needs to be dealt with differently with latest SDK. |
I am not trying to redo any previous transaction @wijskinner |
I'm also getting the same error when creating token second time with different card. My code: The same code works well in |
@hbole probably you need to read about idempotency https://stripe.com/docs/api/idempotent_requests also, I'm giving you a timeout for excessive pinging people |
Another fix arrived in beta |
In my case, my app with |
hi @edgarbonillag , it would be great if you create an issue and link it here, probably someone will figure out how to fix it |
Hi @cybergrind , thanks for your comment. I have a project running perfectly with |
Hi @cybergrind and everyone experiencing issues. Just FYI I finally managed to make my project work! 🎉 Basically
on
The cause was that I was using a very old version of
|
Rolled it as public release 9.1.4 |
New version 9.1.4 has missing function. @ReactMethod |
Closing this ticket, so that new users don't think this project is still active. Stripe does not want you using this, and you will find pain if you do; Please migrate to the official @stripe/stripe-react-native package, for your user's safety, and your developer's sanity! See more: #842 |
The com.tinkyapp app version 5 code includes the com.stripe SDK: stripe-android, 10.4.6, which facilitates the transmission or collection of personal and sensitive information. These actions must comply with the Consent and Clear Disclosure Requirements and applicable terms of the Google Play Privacy Policy, as described in the User Data policy.
As of midnight on July 12, 2021 (UTC), new versions of apps containing this version of the SDK that do not comply with the Consent and Clear Disclosure Requirements set forth in the User Data policy will be rejected. Consider upgrading to version 16.9.0, recommended by the SDK vendor. Request more information from the SDK vendor.
The text was updated successfully, but these errors were encountered: