New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keepfd arg is backwards #1

Open

Posnet opened this issue Jan 26, 2018 · 1 comment

Posnet commented Jan 26, 2018 •

edited

Loading

The keepfd arg is backwards for the python3 implementaion:

if keep_fd:
            return socket.fromfd(fd, family, typ, proto)
else:
            return socket.socket(family, typ, proto, fileno=fd)

... Unlike socket.fromfd(), fileno will return the same socket and not a duplicate ...

Duplicate the file descriptor fd (an integer as returned by a file object’s fileno() method) and build a socket object ...

apollo13 commented Jun 13, 2018

@tiran you wanted to get nagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment