Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB01_BACKUP_BLACKOUT parameters ain't working as expected #367

Open
rltas opened this issue Sep 12, 2024 · 0 comments
Open

DB01_BACKUP_BLACKOUT parameters ain't working as expected #367

rltas opened this issue Sep 12, 2024 · 0 comments
Labels

Comments

@rltas
Copy link

rltas commented Sep 12, 2024

Summary

With a blackout period of 1800 to 0800, backups are still running hourly with the default backup begin time of 2am.

Steps to reproduce

compose.yaml:

...
services:
  db-backup:
    image: tiredofit/db-backup:4.1.4
    environment:
      DEFAULT_BACKUP_BEGIN: "0200"
      DB01_BACKUP_INTERVAL: ${DB_BACKUP_INTERVAL:-1440}
      DB01_BACKUP_BLACKOUT_BEGIN: ${DB_BACKUP_BLACKOUT_BEGIN}
      DB01_BACKUP_BLACKOUT_END: ${DB_BACKUP_BLACKOUT_END}
...

.env:

DB_BACKUP_INTERVAL=60
DB_BACKUP_BLACKOUT_BEGIN=1800
DB_BACKUP_BLACKOUT_END=0800

Resulting in this actual container environment:

DB01_BACKUP_BLACKOUT_BEGIN=1800
DB01_BACKUP_BLACKOUT_END=0800
DB01_BACKUP_INTERVAL=60
DEFAULT_BACKUP_BEGIN=0200

What is the expected correct behavior?

Backups aren't running between 1800 and 0800.

Possible fixes

if [ -n "${backup_job_blackout_start}" ] && [ -n "${backup_job_blackout_finish}" ] ; then

transform_backup_instance_variable "${backup_instance_number}" BLACKOUT_BEGIN backup_job_snapshot_blackout_start

Shouldn't these match?

@rltas rltas added the bug label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant