Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 反馈问题:修改菜单栏图标 #351

Closed
4 of 5 tasks
krtttt opened this issue Jan 22, 2024 · 7 comments
Closed
4 of 5 tasks

🐞 反馈问题:修改菜单栏图标 #351

krtttt opened this issue Jan 22, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request fixed in next release The issue will be closed once next release is available

Comments

@krtttt
Copy link

krtttt commented Jan 22, 2024

请先确认以下事项:

  • 已仔细阅读了 README
  • issues 页面搜索过问题(包括已关闭的 issue),但未能找到解决方法
  • Easydict 已升级到 最新版本
  • 我理解并认可上述内容,并理解项目维护者精力有限,不遵循规则的 issue 可能会被无视或直接关闭

问题描述

现菜单栏图标视图不够清晰,文字过小,图标很小气

重现步骤

左:预想
右:现 Easydict 2.5.0

截图

CleanShot 2024-01-22 at 08 46 27@2x

期望结果

应该更改菜单栏图标,或提供自定义

解决方案(可选)

No response

设备型号 && 系统版本

Apple M1 Pro, macOS 14.0

是否愿意提交 PR 解决该问题?

  • 我愿意提交 PR
@krtttt krtttt added the bug Something isn't working label Jan 22, 2024
Copy link

Hello krtttt, Thank you for your first issue contribution 🎉

@tisfeng
Copy link
Owner

tisfeng commented Jan 22, 2024

我觉得这图标看起来还行。

如果只是单单来评价这个图标,那没必要,如果你有其他想法,可以 PR 提供你认为好的图标,我们来看看效果。

image

@tisfeng tisfeng added invalid This doesn't seem right and removed bug Something isn't working labels Jan 22, 2024
@krtttt krtttt closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2024
@tisfeng
Copy link
Owner

tisfeng commented Jan 23, 2024

其实我觉得目前 Easydict 这两个图标都不错,只是为了方便开发调试,区分版本,所以一个用作 release 环境,另一个用作 debug 环境。

后面想了一下,考虑到不同用户偏好不同,可能有人更喜欢 debug 版本的图标,因此感觉可以开放出来,让用户自己去做选择。

image

@tisfeng tisfeng reopened this Jan 23, 2024
@tisfeng tisfeng changed the title 🐞 反馈问题:菜单栏图标字体可视性低 🐞 反馈问题:修改菜单栏图标 Jan 23, 2024
@tisfeng
Copy link
Owner

tisfeng commented Jan 23, 2024

@choykarl 你可以加一下这个功能吗?就在新的设置页用 Picker 添加一个图标设置项,目前暂定上面那两个选项,默认还是之前 release 版本的图标。

@tisfeng tisfeng added enhancement New feature or request and removed invalid This doesn't seem right labels Jan 23, 2024
@choykarl
Copy link
Collaborator

可以,不过我这个月刚换了工作,现在一边熟悉项目一边做需求,忙到飞起🤣。
不急的话我抽节假日看看。

@tisfeng
Copy link
Owner

tisfeng commented Jan 23, 2024

可以

@tisfeng tisfeng added the fixed in next release The issue will be closed once next release is available label Feb 1, 2024
@tisfeng
Copy link
Owner

tisfeng commented Feb 9, 2024

2.6.0 新版本已提供菜单栏图标选项。

@tisfeng tisfeng closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in next release The issue will be closed once next release is available
Projects
None yet
Development

No branches or pull requests

3 participants