-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 Bug Report: Apple Dict doesn't work in some languages #677
Comments
Hello windrunner414, Thank you for your first issue contribution 🎉 |
Just had a look into code. Maybe it doesn't even query the dictionary because word count > 1
It appears Chinese bypasses the word count check in I don't have a dev environment to debug it now, I probably can take a closer look some time later though. |
ok, I'll take a look at it later. |
This is a bug. The Apple dictionary query should not call the I have removed this check #681, and the next version will fix it. |
Hello, the new version 2.10.0 has fixed this issue. |
Please confirm the following:
Problem description
Apple Dict in Easydict returns no result when the query text contains hiragana/katakana (Japanese) or some Swedish letters (å, ä, ö). I only tested Japanese and Swedish, it's possible that all characters other than Chinese and Latin don't work.
For example, はなし:
超級クラウン中日辞典 / クラウン日中辞典 (the built-in one in apple dictionary):
Easydict:
However, 話 will return the correct results
Is the issue consistently reproducible?
Reproducible
Steps to Reproduce
Screenshot
Runtime log(zip file)
Sorry there are too many menu icons on my laptop and the easydict one is not showing up, I'll try to get the log later
Expected result
Easydict shows the correct result as Apple Dictionary does
Proposed solution (optional)
No response
Device type and OS version
Apple M1 Pro, MacOS 14.6.1
Are you willing to submit a PR to fix this issue?
The text was updated successfully, but these errors were encountered: