-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[view-utilities, router] routelist에 라운지홈을 추가합니다. useNavigate에서 deeplink 이동 로직을 추가합니다. #3486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3486 +/- ##
=======================================
Coverage 14.38% 14.38%
=======================================
Files 729 729
Lines 10313 10313
Branches 3479 3479
=======================================
Hits 1484 1484
Misses 8400 8400
Partials 429 429 ☔ View full report in Codecov by Sentry. |
release-canary |
v14.0.5-pr-3486.4 has been published! |
dongoc
requested review from
zzolain,
sohnjunior,
torres-triple and
guswl98
and removed request for
a team
November 28, 2024 02:20
release-canary |
v14.0.5-pr-3486.5 has been published! |
dongoc
changed the title
[view-utilities] routelist에 라운지홈을 추가합니다.
[view-utilities, router] routelist에 라운지홈을 추가합니다. useNavigate에서 deeplink 이동 로직을 추가합니다.
Nov 29, 2024
drakang4
approved these changes
Nov 29, 2024
guswl98
approved these changes
Nov 29, 2024
🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
[view-utilities] routelist에 라운지홈을 추가합니다.
[router] useNavigate에서 showAppInstallCtaModal을 호출할 때 deeplink로 이동할 수 있도록 수정합니다.