Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[view-utilities, router] routelist에 라운지홈을 추가합니다. useNavigate에서 deeplink 이동 로직을 추가합니다. #3486

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

dongoc
Copy link
Contributor

@dongoc dongoc commented Nov 28, 2024

PR 설명

[view-utilities] routelist에 라운지홈을 추가합니다.
[router] useNavigate에서 showAppInstallCtaModal을 호출할 때 deeplink로 이동할 수 있도록 수정합니다.

@dongoc dongoc added this to the v14.0.5 milestone Nov 28, 2024
@dongoc dongoc self-assigned this Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.38%. Comparing base (c481447) to head (0614260).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3486   +/-   ##
=======================================
  Coverage   14.38%   14.38%           
=======================================
  Files         729      729           
  Lines       10313    10313           
  Branches     3479     3479           
=======================================
  Hits         1484     1484           
  Misses       8400     8400           
  Partials      429      429           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dongoc
Copy link
Contributor Author

dongoc commented Nov 28, 2024

release-canary

Copy link

v14.0.5-pr-3486.4 has been published!

@dongoc dongoc marked this pull request as ready for review November 28, 2024 02:20
@dongoc dongoc requested a review from a team as a code owner November 28, 2024 02:20
@dongoc dongoc requested review from zzolain, sohnjunior, torres-triple and guswl98 and removed request for a team November 28, 2024 02:20
@dongoc dongoc marked this pull request as draft November 28, 2024 07:45
@dongoc
Copy link
Contributor Author

dongoc commented Nov 28, 2024

release-canary

Copy link

v14.0.5-pr-3486.5 has been published!

@dongoc dongoc changed the title [view-utilities] routelist에 라운지홈을 추가합니다. [view-utilities, router] routelist에 라운지홈을 추가합니다. useNavigate에서 deeplink 이동 로직을 추가합니다. Nov 29, 2024
@dongoc dongoc requested a review from drakang4 November 29, 2024 02:52
@dongoc dongoc marked this pull request as ready for review November 29, 2024 02:52
@dongoc
Copy link
Contributor Author

dongoc commented Nov 29, 2024

🙇‍♂️

@dongoc dongoc merged commit f063c15 into main Nov 29, 2024
16 checks passed
@dongoc dongoc deleted the add/intro-home-route branch November 29, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants