Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyntaxWarning: is not with a literal #11

Open
raffaem opened this issue Sep 30, 2022 · 1 comment
Open

SyntaxWarning: is not with a literal #11

raffaem opened this issue Sep 30, 2022 · 1 comment

Comments

@raffaem
Copy link

raffaem commented Sep 30, 2022

mypy throws these warnings.

Are you interested in a PR that fixes this?

[...]/.local/lib/python3.10/site-packages/scipdf/pdf/parse_pdf.py:114: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if middlename is not "":
@mohibullah70
Copy link
Contributor

Issue Resolved

Hi @raffaem ,

Thank you for bringing this! I'm happy to inform you that your concern has been addressed with the recent pull request #21. The syntax warnings you reported have been fixed in the parse_pdf.py file.

Specifically, the pull request addressed the following warnings:
parse_pdf.py:126: "is not" with a literal.
parse_pdf.py:213: "is not" with a literal.
parse_pdf.py:241: "is" with a literal.
parse_pdf.py:254: "is not" with a literal.
parse_pdf.py:303: "is not" with a literal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants