fix: webpack 4

[getkey]

This PR fixes API changes introduced in Webpack 4.

[tivac]

@getkey Thanks! Is this actually testing against webpack@4?

[getkey]

Right, I forgot to run the tests. I also need to update the devDependency. I'll do it tomorrow because I'm in bed now. ;-)

[getkey]

A bunch of tests are failing because webpack@4 prepends ./dist/ to the output path.

[tivac]

Neat, I'll take a look when I get into the office in a bit. May just need to tweak the test webpack configs, hopefully.

[tivac]

Most of the failures seem to be around webpack@4 defaulting to production mode. I'm working on finalizing the test cleanup in a branch that I'll merge manually.

https://github.com/tivac/modular-css/tree/pr/413

Having some weird output from the test that runs webpack multiple times w/ changed file contents though, will need to investigate that further I think.

[tivac]

Looks like compiler.plugin("invalid") is no longer triggering, so my plugin happily barfs out the cached contents forever.

😒

I'll need to do some research on what replaced that event. I love major version upgrades!

[deflock]

compiler.hooks.invalid.tap(...)

https://github.com/webpack/webpack.js.org/blob/next/src/content/api/plugins.md

[tivac]

@deflock I tried that, it never seems to get invoked either. 😒

[tivac]

Tracked it down, fixing the last few Travis failures now.

[tivac]

@getkey published as modular-css-webpack@8.2.0

Thanks again! 🎉

[getkey]

Awesome, thanks @tivac!

If I understand correctly #409, support for Webpack 2 & 3 is dropped for the moment, right?

[tivac]

AFAIK this version should be compatible with webpack 2-4, though testing it against multiple versions is challenge.

[getkey]

Ah alright, yes! 🙂