Add support for <link> elements in svelte components #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only supporting single file component
<style>, this adds support for<link>tags that reference an external stylesheet. Part of the impetus behind this is making transitioning from the old-styleimport css from "./styles.css";flow easier to transition away from. Before you'd need to copy the contents of the CSS file into the svelte component. Now the process is deleting some code from inside the<script>block and turning theimportinto a<link>.It also makes referencing classes/values from component-level CSS possible, because modular-css already knows how to process a CSS file. It doesn't know anything about a svelte HTML file though & it'd be a ton of work to add support for that.
So now there's an easy transitional path from the old-style css-as-data model to the preprocessor world where most classes can be completely static!