-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework svelte & clean up rollup integrations #430
Merged
Merged
+1,079
−763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's sort of a hack but works around rollup tree-shaking away the CSS imports (since they aren't technically being used by the JS code).
Also basic sanity
It's very simple and bad!
Also improve test coverage!
Absolutes are a) silly and b) impossible to snapshot
Also remove some very repetitive paths
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
- Coverage 99.1% 99.08% -0.02%
==========================================
Files 36 31 -5
Lines 779 765 -14
Branches 113 114 +1
==========================================
- Hits 772 758 -14
Misses 7 7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modular-css-rollup
insteadmodular-css-rollup
now supports acommon
option that will handle outputting any CSS that was removed from chunks due to treeshaking.modular-css-rollup
accepts a newprocessor
option that is expected to be a fully-configured & instantiated instance ofProcessor
frommodular-css-core
.