Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework svelte & clean up rollup integrations #430

Merged
merged 14 commits into from
Jun 8, 2018
Merged

Rework svelte & clean up rollup integrations #430

merged 14 commits into from
Jun 8, 2018

Conversation

tivac
Copy link
Owner

@tivac tivac commented Jun 8, 2018

  • Svelte no longer has a custom rollup integration, use modular-css-rollup instead
  • modular-css-rollup now supports a common option that will handle outputting any CSS that was removed from chunks due to treeshaking.
  • modular-css-rollup accepts a new processor option that is expected to be a fully-configured & instantiated instance of Processor from modular-css-core.
  • Updated svelte docs

@codecov
Copy link

codecov bot commented Jun 8, 2018

Codecov Report

Merging #430 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage    99.1%   99.08%   -0.02%     
==========================================
  Files          36       31       -5     
  Lines         779      765      -14     
  Branches      113      114       +1     
==========================================
- Hits          772      758      -14     
  Misses          7        7
Impacted Files Coverage Δ
packages/svelte/svelte.js 100% <100%> (ø) ⬆️
packages/svelte/src/markup.js 100% <100%> (ø)
packages/rollup/rollup.js 100% <100%> (ø) ⬆️
packages/svelte/src/style.js 100% <100%> (ø)
packages/test-utils/read.js
packages/test-utils/namer.js
packages/test-utils/exists.js
packages/test-utils/prefix.js
packages/test-utils/relative.js
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6746694...3009910. Read the comment docs.

@tivac tivac merged commit c80dafe into master Jun 8, 2018
@tivac tivac deleted the rollup-imports branch June 8, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants