fix: support mismatched case when invalidating #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 40 40
Lines 924 924
Branches 139 138 -1
=======================================
Hits 916 916
Misses 8 8
Continue to review full report at Codecov.
|
tivac
added a commit
that referenced
this pull request
Jan 9, 2019
Means that files w/ incorrect cases are supported correctly, and supersedes #533
|
Fixed in a better way in b5a539b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
watchChangeinvalidation that landed in v19 was trying to be clever, which it turns out is a problem when your filenames might have mismatched cases (thanks Windows!).Instead let the already-existing
Processorlogic inside.invalidate()handle it, and then just silently eat errors for files that theProcessordoesn't know about.NO TESTS because they'd never run on anything but a windows machine anyways and that's a PITA to set up.