-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect asset name when entry point name contains [hash] #560
Comments
Almost certainly a bug in here: modular-css/packages/rollup/parser.js Line 13 in 7655d72
Unfortunately I still don't think there's an easier way to get that info, so I'll have to add a failing test and work backwards. |
Maybe something like this:
? |
Working on a change to how assets are chunked/named that sidesteps this problem by naming them after the CSS file, not the JS entry file. It's just too painful to try and figure out with the info rollup currently gives me. Working on that over here, almost done: https://github.com/tivac/modular-css/tree/corrected-chunking |
Expected Behavior
Given the rollup config:
Expect the generated css name to be
dash-entry.abababab.css
.Current Behavior
The generated css name is
entry.abababab.css
(missingdash-
).If I remove the
[hash]
from entryFileNames, then everything works as expected.Also, if the input name doesn't have a '-', then the asset name is correctly generated as well.
Your Environment
modular-css
The text was updated successfully, but these errors were encountered: