Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes svelte doesn't find new classes #571

Closed
tivac opened this issue Mar 26, 2019 · 0 comments · Fixed by #580
Closed

Sometimes svelte doesn't find new classes #571

tivac opened this issue Mar 26, 2019 · 0 comments · Fixed by #580

Comments

@tivac
Copy link
Owner

tivac commented Mar 26, 2019

Expected Behavior

When a new class is added to a CSS file referenced via <link> the @modular-css/svelte plugin should properly pick that up and replace it in markup.

Current Behavior

New classes aren't found until the watcher is restarted.

Possible Solution

Steps to Reproduce (for bugs)

  1. Create a component referencing CSS via <link>
  2. Start a rollup watcher
  3. Add a referenced to a non-existant class in the CSS
  4. Add the class in the CSS
  5. 🔥 when you try to run the generated code because the {css.<class>} wasn't replaced at build time

Context

Your Environment

Executable Version
@modular-css/rollup 22.3.0
@modular-css/rollup-rewriter 22.2.0
@modular-css/shortnames 22.1.4
@modular-css/svelte 22.1.4
rollup 1.1.2
npm --version 6.4.1
node --version 10.12.0
OS Version
Windows 10 14393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant