Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace multiple missing values #576

Merged
merged 2 commits into from
Mar 28, 2019
Merged

fix: replace multiple missing values #576

merged 2 commits into from
Mar 28, 2019

Conversation

tivac
Copy link
Owner

@tivac tivac commented Mar 28, 2019

Description

Make sure that multiple {css.key} values will be replaced if they don't exist in referenced CSS.

Motivation and Context

Fixes #575

How Has This Been Tested?

Updated specimens & snapshots, saw it fail to replace multiple values. Updated svelte.js and now they're correctly replaced.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@0fc5403). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #576   +/-   ##
=========================================
  Coverage          ?   98.98%           
=========================================
  Files             ?       47           
  Lines             ?     1178           
  Branches          ?      183           
=========================================
  Hits              ?     1166           
  Misses            ?       12           
  Partials          ?        0
Impacted Files Coverage Δ
packages/svelte/svelte.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc5403...652898e. Read the comment docs.

@tivac tivac merged commit d48ac67 into master Mar 28, 2019
@tivac tivac deleted the svelte-multiple-missing branch March 28, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v23 doesn't replace multiple invalid {css.key} entries
1 participant