Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't assume plugin key on messages #712

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Jan 8, 2020

when passing custom plugins you may get messages that don't have this key

@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for m-css failed.

Built with commit e9a151c

https://app.netlify.com/sites/m-css/deploys/5e1622fa30d5650008ce2bea

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #712 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #712   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files          45       45           
  Lines        1168     1168           
  Branches      181      181           
=======================================
  Hits         1150     1150           
  Misses         15       15           
  Partials        3        3
Impacted Files Coverage Δ
packages/processor/processor.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ebf81...e9a151c. Read the comment docs.

@tivac tivac merged commit 3a5279c into tivac:master Jan 8, 2020
@tivac
Copy link
Owner

tivac commented Jan 8, 2020

Oof, good catch!

@jquense jquense deleted the patch-1 branch January 8, 2020 21:12
@jquense
Copy link
Contributor Author

jquense commented Jan 20, 2020

@tivac could we get a release on for this :)

@tivac
Copy link
Owner

tivac commented Jan 20, 2020

As soon as I can, had my hands full for work for a bit here :(

@tivac
Copy link
Owner

tivac commented Jan 23, 2020

Just published this as v25.3.1

@jquense
Copy link
Contributor Author

jquense commented Jan 23, 2020

awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants