feat: add .root() to avoid re-parsing inputs when possible
#717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
+ Coverage 98.44% 98.46% +0.02%
==========================================
Files 45 45
Lines 1157 1173 +16
Branches 179 182 +3
==========================================
+ Hits 1139 1155 +16
Misses 15 15
Partials 3 3
Continue to review full report at Codecov.
|
tivac
reviewed
Feb 5, 2020
packages/processor/processor.js
Outdated
| @@ -351,7 +362,7 @@ class Processor { | |||
|
|
|||
| // Take a file id and some text, walk it for dependencies, then | |||
| // process and return details | |||
| async _add(id, text) { | |||
| async _add(id, textOrRoot) { | |||
packages/processor/processor.js
Outdated
| @@ -424,7 +435,7 @@ class Processor { | |||
|
|
|||
| // Process files and walk their composition/value dependency tree to find | |||
| // new files we need to process | |||
| async _walk(name, text) { | |||
| async _walk(name, textOrRoot) { | |||
packages/processor/processor.js
Outdated
| @@ -433,6 +444,10 @@ class Processor { | |||
| return; | |||
| } | |||
|
|
|||
| const text = typeof textOrRoot === "string" ? | |||
There was a problem hiding this comment.
Do this inside the assignment to this._files[name] since nothing else depends on it.
|
@jquense this is great and I'm kinda gobsmacked I didn't already add this 😳 Thanks! |
tivac
changed the title
root() to avoid re-parsing inputs when possible.root() to avoid re-parsing inputs when possible
|
thanks! |
|
This is released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accept a postcss Root object as an input. Allows for minor optimization in a tool chain, where the input may also be using postcss...such as webpack loader chain, where the previous loader may return it's AST as well as the resulting string.
Motivation and Context
nitty-gritty optimization territory. Cases where it doesn't make sense, or not preferable to pass plugins directly to
processor.before.How Has This Been Tested?
I added a test!
Types of changes
Checklist: