fix(webpack): don't try to emit if there were errors #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the loader it easier to get access to
tivac
changed the title
|
Nice! Awesome work. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns out that even if a loader throws an error webpack will still happily fire the
emitevent to plugins. Unclear why, but needed to add some bomb-proofing there so that@modular-css/webpack/pluginwouldn't try to generate output from invalid input files that had already errored out.Motivation and Context
Fixes #724
How Has This Been Tested?
Ran tests locally, also, Travis.
Types of changes
Checklist:
/CC @chiel