Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support escaped characters in composed class names #755

Merged
merged 1 commit into from
May 7, 2020

Conversation

jquense
Copy link
Contributor

@jquense jquense commented May 5, 2020

Description

Support for more valid classnames, helpful with tailwindCSS which uses classes like hover:bg-red

implementation borrowed mostly from https://github.com/pegjs/pegjs/blob/v0.10.0/examples/css.pegjs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Support for more valid classnames, helpful with tailwindCSS which uses classes like `hover:bg-red`
@tivac tivac changed the title Support escaped characters in composed class names feat: Support escaped characters in composed class names May 7, 2020
@tivac tivac merged commit 6cd4d8a into tivac:master May 7, 2020
@tivac
Copy link
Owner

tivac commented May 7, 2020

Thanks!

@jquense jquense deleted the escap-seq branch May 8, 2020 20:04
@jquense
Copy link
Contributor Author

jquense commented May 15, 2020

thank you 👍 any chance of getting a release soon?

@tivac
Copy link
Owner

tivac commented May 15, 2020

I was waiting to clump it together with somethin else, but uh... I don't remember what that was going to be. I'll cut a release in a minute here.

@tivac
Copy link
Owner

tivac commented May 15, 2020

released in 25.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants