Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www): Heading ids are hierarchical #814

Merged
merged 1 commit into from
Feb 25, 2022
Merged

feat(www): Heading ids are hierarchical #814

merged 1 commit into from
Feb 25, 2022

Conversation

tivac
Copy link
Owner

@tivac tivac commented Feb 25, 2022

Description

Make slug generation hierarchical based on heading ranks.

Motivation and Context

Allows for better, nicer visual presentation of the headings while still maintaining very meaningful and stable anchors.

How Has This Been Tested?

Ran site locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Allows for better, nicer visual presentation of the headings while still maintaining very meaningful and stable anchors.
@tivac tivac self-assigned this Feb 25, 2022
@ghost
Copy link

ghost commented Feb 25, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@netlify
Copy link

netlify bot commented Feb 25, 2022

✔️ Deploy Preview for m-css ready!

🔨 Explore the source changes: 0f8ffd4

🔍 Inspect the deploy log: https://app.netlify.com/sites/m-css/deploys/6219201ba7659200074b6cd6

😎 Browse the preview: https://deploy-preview-814--m-css.netlify.app

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #814 (0f8ffd4) into main (b76ded7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          34       34           
  Lines        1389     1389           
  Branches      227      227           
=======================================
  Hits         1383     1383           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b76ded7...0f8ffd4. Read the comment docs.

@tivac tivac merged commit 41b3199 into main Feb 25, 2022
@tivac tivac deleted the hierarchical-slugs branch February 25, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant