Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build on python 3.11 #1

Closed
JC3 opened this issue Oct 3, 2023 · 3 comments
Closed

Does not build on python 3.11 #1

JC3 opened this issue Oct 3, 2023 · 3 comments

Comments

@JC3
Copy link

JC3 commented Oct 3, 2023

  × Building wheel for pyfastnoiselite (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.macosx-13-arm64-cpython-311
      creating build/lib.macosx-13-arm64-cpython-311/pyfastnoiselite
      copying src/pyfastnoiselite/__init__.py -> build/lib.macosx-13-arm64-cpython-311/pyfastnoiselite
      running build_ext
      building 'pyfastnoiselite.pyfastnoiselite' extension
      creating build/temp.macosx-13-arm64-cpython-311
      creating build/temp.macosx-13-arm64-cpython-311/src
      creating build/temp.macosx-13-arm64-cpython-311/src/pyfastnoiselite
      clang -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX13.sdk -Iext/FastNoise -Iext/CPPWrapper -I/Users/cipriani_pro2023/pyenv-zed/include -I/opt/homebrew/opt/python@3.11/Frameworks/Python.framework/Versions/3.11/include/python3.11 -c src/pyfastnoiselite/pyfastnoiselite.cpp -o build/temp.macosx-13-arm64-cpython-311/src/pyfastnoiselite/pyfastnoiselite.o -std=c++11 -stdlib=libc++
      src/pyfastnoiselite/pyfastnoiselite.cpp:220:12: fatal error: 'longintrepr.h' file not found
        #include "longintrepr.h"
                 ^~~~~~~~~~~~~~~
      1 error generated.
      error: command '/usr/bin/clang' failed with exit code 1

Apparently longintrepr.h was moved to a subfolder in 3.11: cython/cython#4461

@tcdude
Copy link
Member

tcdude commented Oct 4, 2023

Should be fixed with the latest commit I pushed.

Thank you

@tcdude tcdude closed this as completed Oct 4, 2023
@JC3
Copy link
Author

JC3 commented Oct 4, 2023

@tcdude Sweet, thanks. Any chance you could push the latest version to PyPI? :)

@tcdude
Copy link
Member

tcdude commented Oct 4, 2023

I tried to adapt my outdated CI workflow to something more modern.. Doesn't like to play well with PyPy and I also skip 32bit binaries (because it's 2023..), but a new release should be up after the current run finishes..

So if you're using a 32 bit system or PyPy, no binaries for you! (or feel free to debug and fix the cibuildwheel workflow for those and make a PR, otherwise)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants