[Feature] Support issue comment created trigger scenario in pull request

[hansarh]

Is this feature missing in the latest version?

• I'm using the latest release

Is your feature request related to a problem? Please describe.

I'm using the branch deploy action which is triggered on in Pull requests:

# The workflow to execute on is comments that are newly created
on:
  issue_comment:
    types: [created]

For this trigger the github context is the default branch which I'm changing to the PR branch by using the ref output of branch-deploy.
I'm using the sha output of branch deploy as input for sha in this action, but it seems like it only checks for changes against the previous commit in this scenario.

      - uses: actions/checkout@v3
        with:
          ref: ${{ inputs.ref }}
          fetch-depth: 0

      # Check if any files in the src/app folder has changed
      - name: Check changes in source code folder
        id: changed-files-specific
        uses: tj-actions/changed-files@v39
        with:
          files: '${{inputs.srcdir}}/**'
          sha: ${{ inputs.sha }}

Describe the solution you'd like?

I want it to work more like the PR scenario where it checks against the default branch or the base_sha of the PR branch. I guess it would work if I was able to in addition input the base_sha, but I only have base_ref as an output from the branch deploy action.

Is there any way you see I can achieve this?

Describe alternatives you've considered?

No response

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[jackton1]

HI @hansarh you can use the base_sha input in that case passing the base_ref output from the branch-deploy action.

Here is an example:

- name: Get changed files
  id: changed-files
  uses: tj-actions/changed-files@v39
  with:
    sha: ${{ inputs.sha }}
    base_sha: ${{ steps.branch-deploy.outputs.base_ref }}
    files: '${{inputs.srcdir}}/**'

[hansarh]

Thanks for the reply. I've tried passing in the base_ref output from the branch deploy action and also using github.base_ref as the default input for base_sha used when context is pr and push to main. They both seems to just generate the value main since I'm testing with a branch to merge to main. This generates an error:

I'm using fetch depth 0 in the checkout action. Any ideas to how I can fix this?
@jackton1

[jackton1]

Hi @hansarh, okay looks like this might not be fully supported yet. I'll reopen this issue and add support for passing the branch names instead of the commit sha